Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move log handlers call so it is only called once per function app #17

Merged
merged 8 commits into from
Feb 14, 2024
Merged

Move log handlers call so it is only called once per function app #17

merged 8 commits into from
Feb 14, 2024

Conversation

Iain-S
Copy link
Contributor

@Iain-S Iain-S commented Feb 5, 2024

No description provided.

@Iain-S Iain-S requested a review from dlpbc February 5, 2024 16:36
@Iain-S Iain-S added the WIP Work In Progress (don't merge) label Feb 5, 2024
@Iain-S

This comment was marked as outdated.

Sign in to view
@Iain-S
Copy link
Contributor Author

Iain-S commented Feb 6, 2024 •
edited by dlpbc
Loading

To do:

  • status function
  • usage function
  • controller function

@Iain-S
Copy link
Contributor Author

Iain-S commented Feb 12, 2024

@dlpbc notice that I have moved the add_log_handler call back into main and changed it to return if it is called a second time rather than raise. This simplifies testing and ensures that importing status has fewer side-effects.

@Iain-S Iain-S removed the WIP Work In Progress (don't merge) label Feb 14, 2024
@Iain-S Iain-S merged commit 3f88af2 into main Feb 14, 2024
8 checks passed
@Iain-S Iain-S deleted the logging_handler branch February 14, 2024 09:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dlpbc dlpbc Awaiting requested review from dlpbc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Iain-S @dlpbc